[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 14 09:32:49 PDT 2019


lebedev.ri added a comment.

In D59214#1429422 <https://reviews.llvm.org/D59214#1429422>, @riccibruno wrote:

> In D59214#1429400 <https://reviews.llvm.org/D59214#1429400>, @lebedev.ri wrote:
>
> > In D59214#1429384 <https://reviews.llvm.org/D59214#1429384>, @riccibruno wrote:
> >
> > > IIRC, last time I looked only 4 statement/expression classes currently have some abbreviation defined.
> >
> >
> > Yep, that is what i'm seeing in this diff.
> >
> > In D59214#1429384 <https://reviews.llvm.org/D59214#1429384>, @riccibruno wrote:
> >
> > > It would probably be useful to have someone go systematically through the list of classes and fix this.
> >
> >
> > Yeah, i suspect that might be **really** beneficial.
>
>
> Especially given that more people are going to use modules now that they are in the process of being standardized.


Ah, good point, filed https://bugs.llvm.org/show_bug.cgi?id=41072


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59214/new/

https://reviews.llvm.org/D59214





More information about the cfe-commits mailing list