[LLVMdev] LLVM with Microsoft Visual Studio

[Jeff Cohen]

No, the problem with StoreSDNode was that an argument as being called 
Value, which hid the class Value later on in the argument list.  This 
also broke 2003 and was fixed a while ago.

 _WIN32_WINNT is not supposed to be predefined, so that warning 
shouldn't be occurring.  I have never seen it myself, and a predefined 
value could be inappropriate.

Most of the other changes seem to be about inserting casts, and I'd like 
to know what errors they are fixing.  The casts are not needed with GCC 
or VS 2003.

Andreas Fredriksson wrote:
> On 3/11/07, Reid Spencer <rspencer at reidspencer.com> wrote:
>
>> Could you submit the patch? We could make sure that 2.0 doesn't have the
>> same problem.
>
> Sure, I can't test this from where I am now but if anyone can take it
> for a spin to test it and verify the fix then by all means check it
> in. I'm just providing a hand-edited diff from our vendor branch here
> (1.9 tarball version); it's the best I can do right now.
>
> I think the most important part was the change to the StoreSDNode
> constructor which relied on implicit type lookup.
>
> // Andreas
> ------------------------------------------------------------------------
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20070310/33b6441c/attachment.html>