<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
No, the problem with StoreSDNode was that an argument as being called
Value, which hid the class Value later on in the argument list. This
also broke 2003 and was fixed a while ago.<br>
<br>
_WIN32_WINNT is not supposed to be predefined, so that warning
shouldn't be occurring. I have never seen it myself, and a predefined
value could be inappropriate.<br>
<br>
Most of the other changes seem to be about inserting casts, and I'd
like to know what errors they are fixing. The casts are not needed
with GCC or VS 2003.<br>
<br>
Andreas Fredriksson wrote:
<blockquote
cite="mid3212b1a80703101532o255d1effycd0cee7633d13e2d@mail.gmail.com"
type="cite">On 3/11/07, Reid Spencer <a class="moz-txt-link-rfc2396E" href="mailto:rspencer@reidspencer.com"><rspencer@reidspencer.com></a>
wrote:
<br>
<br>
<blockquote type="cite">Could you submit the patch? We could make
sure that 2.0 doesn't have the
<br>
same problem.
<br>
</blockquote>
<br>
Sure, I can't test this from where I am now but if anyone can take it
<br>
for a spin to test it and verify the fix then by all means check it
<br>
in. I'm just providing a hand-edited diff from our vendor branch here
<br>
(1.9 tarball version); it's the best I can do right now.
<br>
<br>
I think the most important part was the change to the StoreSDNode
<br>
constructor which relied on implicit type lookup.
<br>
<br>
// Andreas
<br>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a class="moz-txt-link-freetext" href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a>
</pre>
</blockquote>
</body>
</html>