[Openmp-commits] [openmp] d5194e2 - [libomp] Add kmp_vector (ADT 2/2) (#176163)

via Openmp-commits openmp-commits at lists.llvm.org
Wed Jun 17 23:11:40 PDT 2026


Author: Robert Imschweiler
Date: 2026-06-18T08:11:35+02:00
New Revision: d5194e2514533067c5a7a7c2e7af33b112e3aad5

URL: https://github.com/llvm/llvm-project/commit/d5194e2514533067c5a7a7c2e7af33b112e3aad5
DIFF: https://github.com/llvm/llvm-project/commit/d5194e2514533067c5a7a7c2e7af33b112e3aad5.diff

LOG: [libomp] Add kmp_vector (ADT 2/2) (#176163)

See rationale in the commit adding kmp_str_ref.

This commit introduces kmp_vector, a class intended primarily for small
vectors. It currently only includes methods I need at the moment, but
it's easily extensible.

Added: 
    openmp/runtime/unittests/ADT/TestVector.cpp

Modified: 
    openmp/runtime/src/kmp_adt.h
    openmp/runtime/unittests/ADT/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/openmp/runtime/src/kmp_adt.h b/openmp/runtime/src/kmp_adt.h
index c0321d9faefb3..541fd827f8fea 100644
--- a/openmp/runtime/src/kmp_adt.h
+++ b/openmp/runtime/src/kmp_adt.h
@@ -25,8 +25,11 @@
 #include <cstddef>
 #include <cstdint>
 #include <cstring>
+#include <memory>
 #include <type_traits>
 
+#include "kmp.h"
+
 /// kmp_str_ref is a non-owning string class (similar to llvm::StringRef).
 class kmp_str_ref final {
   const char *data;
@@ -139,4 +142,195 @@ class kmp_str_ref final {
   const char *end() const { return data + len; }
 };
 
+/// kmp_vector is a vector class for managing small vectors.
+/// INLINE_THRESHOLD: Number of elements in the inline array. If exceeded, the
+/// vector will grow dynamically.
+template <typename T, size_t INLINE_THRESHOLD = 8> class kmp_vector final {
+  static_assert(std::is_copy_constructible_v<T>,
+                "T must be copy constructible");
+  static_assert(std::is_destructible_v<T>, "T must be destructible");
+
+  struct default_eq {
+    bool operator()(const T &a, const T &b) const { return a == b; }
+  };
+
+  T inline_data[INLINE_THRESHOLD];
+  T *data = inline_data;
+  size_t count = 0;
+  size_t capacity = INLINE_THRESHOLD;
+
+  void copy_data(T *dst, const T *src, size_t num_elements) {
+    if constexpr (std::is_trivially_copyable_v<T>) {
+      memcpy(dst, src, num_elements * sizeof(T));
+    } else {
+      for (size_t i = 0; i < num_elements; i++)
+        new (&dst[i]) T(src[i]); // copy-construct to memory
+    }
+  }
+
+  /// Grow by ~1.5x / at least by +1 element.
+  /// If MinSize > 0, grow only if necessary to guarantee space
+  /// for at least MinSize elements.
+  void grow(size_t MinSize = 0) {
+    if (MinSize) {
+      if (MinSize <= capacity)
+        return;
+      capacity = MinSize;
+    } else {
+      capacity = capacity + (capacity / 2) + 1;
+    }
+    T *old_data = data != inline_data ? data : nullptr;
+    data =
+        static_cast<T *>(KMP_INTERNAL_REALLOC(old_data, capacity * sizeof(T)));
+    if (!data)
+      KMP_FATAL(MemoryAllocFailed);
+    // Copy the data to the new array if we didn't use a dynamic array before.
+    if (!old_data)
+      copy_data(data, inline_data, count);
+  }
+
+  void init(size_t new_capacity, const T *init_data, size_t new_count) {
+    assert(new_capacity >= new_count &&
+           "more elements requested than capacity");
+    if (new_capacity > capacity)
+      grow(new_capacity);
+    if (init_data)
+      copy_data(data, init_data, new_count);
+    count = new_count;
+  }
+
+  /// Move data from other vector to this vector (which must be emptied before)
+  void move_from(kmp_vector &&other) {
+    assert(empty() && "must be empty before overwriting");
+    if (other.data == other.inline_data) {
+      // Cannot move inline data, must copy.
+      init(other.capacity, other.data, other.count);
+    } else {
+      // Steal dynamic data.
+      data = other.data;
+      count = other.count;
+      capacity = other.capacity;
+    }
+    other.reset(/*free_data=*/false);
+  }
+
+  void reset(bool free_data) {
+    if (free_data && data != inline_data) {
+      clear();
+      KMP_INTERNAL_FREE(data);
+    }
+    data = inline_data;
+    count = 0;
+    capacity = INLINE_THRESHOLD;
+  }
+
+public:
+  ~kmp_vector() { reset(/*free_data=*/true); }
+
+  explicit kmp_vector(size_t capacity = 0) { init(capacity, nullptr, 0); }
+
+  kmp_vector(size_t capacity, const T *init_data, size_t count) {
+    init(capacity, init_data, count);
+  }
+
+  kmp_vector(const kmp_vector &other) {
+    init(other.capacity, other.data, other.count);
+  }
+
+  kmp_vector(kmp_vector &&other) noexcept { move_from(std::move(other)); }
+
+  kmp_vector &operator=(const kmp_vector &other) {
+    if (this != &other) {
+      reset(/*free_data=*/true);
+      init(other.capacity, other.data, other.count);
+    }
+    return *this;
+  }
+
+  kmp_vector &operator=(kmp_vector &&other) noexcept {
+    if (this != &other) {
+      reset(/*free_data=*/true);
+      move_from(std::move(other));
+    }
+    return *this;
+  }
+
+  /// Destroy all elements in the vector. Doesn't free the memory.
+  void clear() {
+    if constexpr (!std::is_trivially_destructible_v<T>) {
+      for (size_t i = 0; i < count; i++)
+        data[i].~T();
+    }
+    count = 0;
+  }
+
+  /// Check if the vector contains the given value.
+  /// If a comparator is provided, it will be used to compare the values.
+  /// Otherwise, the equality operator will be used.
+  template <typename Fn = default_eq>
+  bool contains(const T &value, const Fn &comp = Fn{}) const {
+    static_assert(std::is_invocable_r_v<bool, Fn, const T &, const T &>,
+                  "predicate must be callable as bool(const T &, const T &)");
+    for (size_t i = 0; i < count; i++) {
+      if (comp(data[i], value))
+        return true;
+    }
+    return false;
+  }
+
+  bool empty() const { return !count; }
+
+  /// Check if the two vectors are equal with set semantics.
+  /// Current implementation is naive O(n^2) and not optimized for performance.
+  /// Handles duplicates correctly.
+  template <typename Fn = default_eq>
+  bool is_set_equal(const kmp_vector &other, const Fn &comp = Fn{}) const {
+    static_assert(std::is_invocable_r_v<bool, Fn, const T &, const T &>,
+                  "predicate must be callable as bool(const T &, const T &)");
+    for (const T &val : *this) {
+      if (!other.contains(val, comp))
+        return false;
+    }
+    for (const T &val : other) {
+      if (!contains(val, comp))
+        return false;
+    }
+    return true;
+  }
+
+  /// Add a new element to the end of the vector.
+  void push_back(const T &value) {
+    if (count == capacity)
+      grow();
+    if constexpr (std::is_trivially_copyable_v<T>)
+      data[count++] = value;
+    else
+      new (&data[count++]) T(value);
+  }
+
+  /// Reserve space for the given number of elements.
+  /// (Note: does not shrink the vector.)
+  void reserve(size_t new_capacity) {
+    if (new_capacity > capacity)
+      grow(new_capacity);
+  }
+
+  size_t size() const { return count; }
+
+  T &operator[](size_t index) {
+    assert(index < count && "Index out of bounds");
+    return data[index];
+  }
+  const T &operator[](size_t index) const {
+    assert(index < count && "Index out of bounds");
+    return data[index];
+  }
+
+  /// Iterator support (raw pointers work as iterators for contiguous storage)
+  T *begin() { return data; }
+  T *end() { return data + count; }
+  const T *begin() const { return data; }
+  const T *end() const { return data + count; }
+};
+
 #endif // KMP_ADT_H

diff  --git a/openmp/runtime/unittests/ADT/CMakeLists.txt b/openmp/runtime/unittests/ADT/CMakeLists.txt
index a29e70afe6df6..ea3a32271b8fc 100644
--- a/openmp/runtime/unittests/ADT/CMakeLists.txt
+++ b/openmp/runtime/unittests/ADT/CMakeLists.txt
@@ -1,4 +1,5 @@
 add_openmp_unittest(ADTTests
   TestStringRef.cpp
+  TestVector.cpp
 )
 

diff  --git a/openmp/runtime/unittests/ADT/TestVector.cpp b/openmp/runtime/unittests/ADT/TestVector.cpp
new file mode 100644
index 0000000000000..dbf74555b879b
--- /dev/null
+++ b/openmp/runtime/unittests/ADT/TestVector.cpp
@@ -0,0 +1,627 @@
+//===- TestVector.cpp - Tests for kmp_vector class -----------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "kmp_adt.h"
+#include "gtest/gtest.h"
+
+namespace {
+
+/// Type-parameterized test fixture so each test runs against multiple
+/// INLINE_THRESHOLD values, exercising both the inline and dynamic paths.
+template <typename Config> class kmp_vector_test : public ::testing::Test {};
+
+template <size_t N> struct InlineThreshold {
+  template <typename T> using Vec = kmp_vector<T, N>;
+  static constexpr size_t value = N;
+};
+
+using InlineThresholds =
+    ::testing::Types<InlineThreshold<0>, InlineThreshold<1>, InlineThreshold<8>,
+                     InlineThreshold<16>>;
+TYPED_TEST_SUITE(kmp_vector_test, InlineThresholds);
+
+//===----------------------------------------------------------------------===//
+// Construction
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, DefaultConstruction) {
+  typename TypeParam::template Vec<int> v;
+  EXPECT_EQ(v.size(), 0u);
+  EXPECT_TRUE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, ConstructWithCapacity) {
+  typename TypeParam::template Vec<int> v(10);
+  EXPECT_EQ(v.size(), 0u);
+  EXPECT_TRUE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, ConstructWithData) {
+  int data[] = {1, 2, 3, 4, 5};
+  typename TypeParam::template Vec<int> v(5, data, 5);
+
+  EXPECT_EQ(v.size(), 5u);
+  EXPECT_EQ(v[0], 1);
+  EXPECT_EQ(v[1], 2);
+  EXPECT_EQ(v[2], 3);
+  EXPECT_EQ(v[3], 4);
+  EXPECT_EQ(v[4], 5);
+}
+
+TYPED_TEST(kmp_vector_test, ConstructWithCapacityLargerThanSize) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(10, data, 3);
+
+  EXPECT_EQ(v.size(), 3u);
+  EXPECT_EQ(v[0], 1);
+  EXPECT_EQ(v[1], 2);
+  EXPECT_EQ(v[2], 3);
+}
+
+//===----------------------------------------------------------------------===//
+// Copy Semantics
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, CopyConstruction) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v1(3, data, 3);
+  typename TypeParam::template Vec<int> v2(v1);
+
+  EXPECT_EQ(v2.size(), 3u);
+  EXPECT_EQ(v2[0], 1);
+  EXPECT_EQ(v2[1], 2);
+  EXPECT_EQ(v2[2], 3);
+
+  // Modify v1, v2 should be unchanged
+  v1[0] = 100;
+  EXPECT_EQ(v2[0], 1);
+}
+
+TYPED_TEST(kmp_vector_test, CopyAssignment) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {4, 5};
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(2, data2, 2);
+
+  v2 = v1;
+
+  EXPECT_EQ(v2.size(), 3u);
+  EXPECT_EQ(v2[0], 1);
+  EXPECT_EQ(v2[1], 2);
+  EXPECT_EQ(v2[2], 3);
+}
+
+TYPED_TEST(kmp_vector_test, SelfCopyAssignment) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  typename TypeParam::template Vec<int> &v_ref = v;
+  v = v_ref; // Avoid self-assignment warning
+
+  EXPECT_EQ(v.size(), 3u);
+  EXPECT_EQ(v[0], 1);
+}
+
+//===----------------------------------------------------------------------===//
+// Move Semantics
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, MoveConstruction) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v1(3, data, 3);
+  typename TypeParam::template Vec<int> v2(std::move(v1));
+
+  EXPECT_EQ(v2.size(), 3u);
+  EXPECT_EQ(v2[0], 1);
+  EXPECT_EQ(v2[1], 2);
+  EXPECT_EQ(v2[2], 3);
+
+  // v1 should be empty after move
+  EXPECT_EQ(v1.size(), 0u);
+}
+
+TYPED_TEST(kmp_vector_test, MoveAssignment) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {4, 5};
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(2, data2, 2);
+
+  v2 = std::move(v1);
+
+  EXPECT_EQ(v2.size(), 3u);
+  EXPECT_EQ(v2[0], 1);
+  EXPECT_EQ(v1.size(), 0u);
+}
+
+TYPED_TEST(kmp_vector_test, SelfMoveAssignment) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  typename TypeParam::template Vec<int> &v_ref = v;
+  v = std::move(v_ref); // Avoid self-move warning
+
+  // Self-move should leave object in valid state
+  EXPECT_EQ(v.size(), 3u);
+  EXPECT_EQ(v[0], 1);
+}
+
+//===----------------------------------------------------------------------===//
+// push_back
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, PushBackToEmpty) {
+  typename TypeParam::template Vec<int> v;
+
+  v.push_back(42);
+
+  EXPECT_EQ(v.size(), 1u);
+  EXPECT_EQ(v[0], 42);
+}
+
+TYPED_TEST(kmp_vector_test, PushBackMultiple) {
+  typename TypeParam::template Vec<int> v;
+
+  v.push_back(1);
+  v.push_back(2);
+  v.push_back(3);
+  v.push_back(4);
+  v.push_back(5);
+
+  EXPECT_EQ(v.size(), 5u);
+  EXPECT_EQ(v[0], 1);
+  EXPECT_EQ(v[1], 2);
+  EXPECT_EQ(v[2], 3);
+  EXPECT_EQ(v[3], 4);
+  EXPECT_EQ(v[4], 5);
+}
+
+TYPED_TEST(kmp_vector_test, PushBackGrowth) {
+  typename TypeParam::template Vec<int> v;
+
+  // Push many elements to trigger multiple resizes
+  for (int i = 0; i < 100; ++i)
+    v.push_back(i);
+
+  EXPECT_EQ(v.size(), 100u);
+  for (int i = 0; i < 100; ++i)
+    EXPECT_EQ(v[i], i);
+}
+
+//===----------------------------------------------------------------------===//
+// clear
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, Clear) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  EXPECT_EQ(v.size(), 3u);
+
+  v.clear();
+
+  EXPECT_EQ(v.size(), 0u);
+  EXPECT_TRUE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, ClearEmpty) {
+  typename TypeParam::template Vec<int> v;
+
+  v.clear();
+
+  EXPECT_EQ(v.size(), 0u);
+  EXPECT_TRUE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, PushBackAfterClear) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  v.clear();
+  v.push_back(42);
+
+  EXPECT_EQ(v.size(), 1u);
+  EXPECT_EQ(v[0], 42);
+}
+
+//===----------------------------------------------------------------------===//
+// empty
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, EmptyOnDefault) {
+  typename TypeParam::template Vec<int> v;
+  EXPECT_TRUE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, NotEmptyAfterPush) {
+  typename TypeParam::template Vec<int> v;
+  v.push_back(1);
+  EXPECT_FALSE(v.empty());
+}
+
+TYPED_TEST(kmp_vector_test, EmptyAfterClear) {
+  typename TypeParam::template Vec<int> v;
+  v.push_back(1);
+  v.clear();
+  EXPECT_TRUE(v.empty());
+}
+
+//===----------------------------------------------------------------------===//
+// contains
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, ContainsFound) {
+  int data[] = {1, 2, 3, 4, 5};
+  typename TypeParam::template Vec<int> v(5, data, 5);
+
+  EXPECT_TRUE(v.contains(1));
+  EXPECT_TRUE(v.contains(3));
+  EXPECT_TRUE(v.contains(5));
+}
+
+TYPED_TEST(kmp_vector_test, ContainsNotFound) {
+  int data[] = {1, 2, 3, 4, 5};
+  typename TypeParam::template Vec<int> v(5, data, 5);
+
+  EXPECT_FALSE(v.contains(0));
+  EXPECT_FALSE(v.contains(6));
+  EXPECT_FALSE(v.contains(-1));
+}
+
+TYPED_TEST(kmp_vector_test, ContainsEmpty) {
+  typename TypeParam::template Vec<int> v;
+
+  EXPECT_FALSE(v.contains(0));
+  EXPECT_FALSE(v.contains(1));
+}
+
+//===----------------------------------------------------------------------===//
+// is_set_equal
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, IsSetEqualSameOrder) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v1(3, data, 3);
+  typename TypeParam::template Vec<int> v2(3, data, 3);
+
+  EXPECT_TRUE(v1.is_set_equal(v2));
+  EXPECT_TRUE(v2.is_set_equal(v1));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualDifferentOrder) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {3, 1, 2};
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(3, data2, 3);
+
+  EXPECT_TRUE(v1.is_set_equal(v2));
+  EXPECT_TRUE(v2.is_set_equal(v1));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualDifferentSize) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {1, 2};
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(2, data2, 2);
+
+  EXPECT_FALSE(v1.is_set_equal(v2));
+  EXPECT_FALSE(v2.is_set_equal(v1));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualDifferentElements) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {1, 2, 4};
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(3, data2, 3);
+
+  EXPECT_FALSE(v1.is_set_equal(v2));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualEmpty) {
+  typename TypeParam::template Vec<int> v1;
+  typename TypeParam::template Vec<int> v2;
+
+  EXPECT_TRUE(v1.is_set_equal(v2));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualWithDuplicates) {
+  int data1[] = {1, 1};
+  int data2[] = {1, 2};
+  typename TypeParam::template Vec<int> v1(2, data1, 2);
+  typename TypeParam::template Vec<int> v2(2, data2, 2);
+
+  EXPECT_FALSE(v1.is_set_equal(v2));
+  EXPECT_FALSE(v2.is_set_equal(v1));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualWithDuplicatesSame) {
+  int data1[] = {1, 1};
+  int data2[] = {1};
+  typename TypeParam::template Vec<int> v1(2, data1, 2);
+  typename TypeParam::template Vec<int> v2(1, data2, 1);
+
+  EXPECT_TRUE(v1.is_set_equal(v2));
+  EXPECT_TRUE(v2.is_set_equal(v1));
+}
+
+//===----------------------------------------------------------------------===//
+// contains with Comparator
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, ContainsWithComparator) {
+  int data[] = {10, 20, 30};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  // Compare by tens digit
+  auto same_tens = [](const int &a, const int &b) {
+    return (a / 10) == (b / 10);
+  };
+
+  EXPECT_TRUE(v.contains(15, same_tens)); // 15/10 == 1, matches 10/10 == 1
+  EXPECT_TRUE(v.contains(25, same_tens)); // 25/10 == 2, matches 20/10 == 2
+  EXPECT_FALSE(v.contains(45, same_tens)); // 45/10 == 4, no match
+}
+
+TYPED_TEST(kmp_vector_test, ContainsPointerWithComparator) {
+  int a = 100, b = 200, c = 300;
+  int *data[] = {&a, &b, &c};
+  typename TypeParam::template Vec<int *> v(3, data, 3);
+
+  // Comparator that compares pointed-to values
+  auto deref_comp = [](int *const &pa, int *const &pb) { return *pa == *pb; };
+
+  int x = 200;
+  int *px = &x;
+
+  // Without comparator: comparing pointers (
diff erent addresses)
+  EXPECT_FALSE(v.contains(px));
+
+  // With comparator: comparing values (200 == 200)
+  EXPECT_TRUE(v.contains(px, deref_comp));
+}
+
+TYPED_TEST(kmp_vector_test, ContainsWithCapturingComparator) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  // Capturing comparator: matches when a + offset == b. This requires the
+  // template functor API; a plain function pointer cannot carry the capture.
+  int offset = 10;
+  auto shifted_eq = [offset](const int &a, const int &b) {
+    return a + offset == b;
+  };
+
+  EXPECT_TRUE(v.contains(11, shifted_eq)); // 1 + 10 == 11
+  EXPECT_TRUE(v.contains(13, shifted_eq)); // 3 + 10 == 13
+  EXPECT_FALSE(v.contains(99, shifted_eq)); // no match
+}
+
+//===----------------------------------------------------------------------===//
+// is_set_equal with Comparator
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, IsSetEqualWithComparator) {
+  int data1[] = {10, 20, 30};
+  int data2[] = {35, 15, 25}; // Same tens digits as data1, 
diff erent order
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(3, data2, 3);
+
+  auto same_tens = [](const int &a, const int &b) {
+    return (a / 10) == (b / 10);
+  };
+
+  // Without comparator: not equal
+  EXPECT_FALSE(v1.is_set_equal(v2));
+
+  // With comparator: equal (same tens digits)
+  EXPECT_TRUE(v1.is_set_equal(v2, same_tens));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualPointerWithComparator) {
+  int a1 = 100, b1 = 200, c1 = 300;
+  int a2 = 100, b2 = 200, c2 = 300;
+  int *data1[] = {&a1, &b1, &c1};
+  int *data2[] = {&c2, &a2, &b2}; // Same values, 
diff erent order and addresses
+  typename TypeParam::template Vec<int *> v1(3, data1, 3);
+  typename TypeParam::template Vec<int *> v2(3, data2, 3);
+
+  auto deref_comp = [](int *const &pa, int *const &pb) { return *pa == *pb; };
+
+  // Without comparator: not equal (
diff erent pointers)
+  EXPECT_FALSE(v1.is_set_equal(v2));
+
+  // With comparator: equal (same pointed-to values)
+  EXPECT_TRUE(v1.is_set_equal(v2, deref_comp));
+}
+
+TYPED_TEST(kmp_vector_test, IsSetEqualWithCapturingComparator) {
+  int data1[] = {1, 2, 3};
+  int data2[] = {13, 11, 12}; // each element of data1 
diff ers by offset
+  typename TypeParam::template Vec<int> v1(3, data1, 3);
+  typename TypeParam::template Vec<int> v2(3, data2, 3);
+
+  // Capturing comparator: matches when the values 
diff er by exactly offset.
+  // is_set_equal invokes the comparator in both argument orders, so it must be
+  // symmetric. This requires the template functor API; a plain function pointer
+  // cannot carry the capture.
+  int offset = 10;
+  auto offset_eq = [offset](const int &a, const int &b) {
+    int 
diff  = a - b;
+    return 
diff  == offset || 
diff  == -offset;
+  };
+
+  // Without comparator: not equal
+  EXPECT_FALSE(v1.is_set_equal(v2));
+
+  // With comparator: equal (each element 
diff ers by offset)
+  EXPECT_TRUE(v1.is_set_equal(v2, offset_eq));
+}
+
+//===----------------------------------------------------------------------===//
+// Indexing
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, IndexOperator) {
+  int data[] = {10, 20, 30};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  EXPECT_EQ(v[0], 10);
+  EXPECT_EQ(v[1], 20);
+  EXPECT_EQ(v[2], 30);
+}
+
+TYPED_TEST(kmp_vector_test, IndexOperatorModify) {
+  int data[] = {10, 20, 30};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  v[1] = 200;
+
+  EXPECT_EQ(v[1], 200);
+}
+
+TYPED_TEST(kmp_vector_test, ConstIndexOperator) {
+  int data[] = {10, 20, 30};
+  const typename TypeParam::template Vec<int> v(3, data, 3);
+
+  EXPECT_EQ(v[0], 10);
+  EXPECT_EQ(v[1], 20);
+  EXPECT_EQ(v[2], 30);
+}
+
+//===----------------------------------------------------------------------===//
+// Iterators
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, BeginEnd) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  int *begin = v.begin();
+  int *end = v.end();
+
+  EXPECT_EQ(end - begin, 3);
+  EXPECT_EQ(*begin, 1);
+  EXPECT_EQ(*(end - 1), 3);
+}
+
+TYPED_TEST(kmp_vector_test, ConstBeginEnd) {
+  int data[] = {1, 2, 3};
+  const typename TypeParam::template Vec<int> v(3, data, 3);
+
+  const int *begin = v.begin();
+  const int *end = v.end();
+
+  EXPECT_EQ(end - begin, 3);
+  EXPECT_EQ(*begin, 1);
+}
+
+TYPED_TEST(kmp_vector_test, RangeBasedFor) {
+  int data[] = {1, 2, 3, 4, 5};
+  typename TypeParam::template Vec<int> v(5, data, 5);
+
+  int sum = 0;
+  for (int x : v)
+    sum += x;
+
+  EXPECT_EQ(sum, 15);
+}
+
+TYPED_TEST(kmp_vector_test, RangeBasedForModify) {
+  int data[] = {1, 2, 3};
+  typename TypeParam::template Vec<int> v(3, data, 3);
+
+  for (int &x : v)
+    x *= 2;
+
+  EXPECT_EQ(v[0], 2);
+  EXPECT_EQ(v[1], 4);
+  EXPECT_EQ(v[2], 6);
+}
+
+TYPED_TEST(kmp_vector_test, RangeBasedForEmpty) {
+  typename TypeParam::template Vec<int> v;
+
+  int count = 0;
+  for (int x : v) {
+    (void)x;
+    count++;
+  }
+
+  EXPECT_EQ(count, 0);
+}
+
+//===----------------------------------------------------------------------===//
+// Edge Cases
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, EmptyVector) {
+  typename TypeParam::template Vec<int> v;
+
+  EXPECT_EQ(v.size(), 0u);
+  EXPECT_EQ(v.begin(), v.end());
+  EXPECT_FALSE(v.contains(0));
+}
+
+TYPED_TEST(kmp_vector_test, SingleElement) {
+  typename TypeParam::template Vec<int> v;
+  v.push_back(42);
+
+  EXPECT_EQ(v.size(), 1u);
+  EXPECT_EQ(v[0], 42);
+  EXPECT_TRUE(v.contains(42));
+  EXPECT_EQ(v.end() - v.begin(), 1);
+}
+
+//===----------------------------------------------------------------------===//
+// Different Types
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, PointerType) {
+  int a = 1, b = 2, c = 3;
+  int *data[] = {&a, &b, &c};
+  typename TypeParam::template Vec<int *> v(3, data, 3);
+
+  EXPECT_EQ(v.size(), 3u);
+  EXPECT_EQ(*v[0], 1);
+  EXPECT_EQ(*v[1], 2);
+  EXPECT_EQ(*v[2], 3);
+}
+
+TYPED_TEST(kmp_vector_test, SizeTType) {
+  size_t data[] = {100, 200, 300};
+  typename TypeParam::template Vec<size_t> v(3, data, 3);
+
+  EXPECT_EQ(v[0], 100u);
+  EXPECT_EQ(v[1], 200u);
+  EXPECT_EQ(v[2], 300u);
+}
+
+//===----------------------------------------------------------------------===//
+// Reserve
+//===----------------------------------------------------------------------===//
+
+TYPED_TEST(kmp_vector_test, Reserve) {
+  typename TypeParam::template Vec<int> v;
+  v.reserve(100);
+
+  EXPECT_EQ(v.size(), 0u);
+
+  // Push one element to get a valid data pointer
+  v.push_back(0);
+  const int *data_ptr = v.begin();
+
+  // Should be able to push without reallocation
+  for (int i = 1; i < 100; ++i)
+    v.push_back(i);
+
+  EXPECT_EQ(v.size(), 100u);
+  EXPECT_EQ(v.begin(), data_ptr) << "Reallocation occurred despite reserve()";
+  for (int i = 0; i < 100; ++i)
+    EXPECT_EQ(v[i], i);
+}
+
+} // namespace


        


More information about the Openmp-commits mailing list