[Openmp-commits] [PATCH] D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins

[Carlo Bertolli via Phabricator via Openmp-commits]

carlo.bertolli added a comment.

I changed the old plugin interface for tgt_rtl_data_lock to return an error code. It now returns the lockedptr as function argument. Let me know if this is not what was called for.
Thanks for this extension!



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:360
 
-Error GenericDeviceTy::registerHostPinnedMemoryBuffer(const void *Buffer,
+Error PinnedAllocationMapTy::registerHostPinnedBuffer(void *HstPtr,
+                                                      void *DevPtr,
----------------
Just a nit: for amdgpu's we don't need to keep a table of locked pointers. This is already done by ROCr. I would consider making this optional for amdgpu's.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141227/new/

https://reviews.llvm.org/D141227