[Openmp-commits] [PATCH] D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins

Kevin Sala Penad├ęs via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 10 10:37:52 PST 2023


kevinsala marked an inline comment as done.
kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:360
 
-Error GenericDeviceTy::registerHostPinnedMemoryBuffer(const void *Buffer,
+Error PinnedAllocationMapTy::registerHostPinnedBuffer(void *HstPtr,
+                                                      void *DevPtr,
----------------
carlo.bertolli wrote:
> Just a nit: for amdgpu's we don't need to keep a table of locked pointers. This is already done by ROCr. I would consider making this optional for amdgpu's.
You're right. But for the moment, we want to keep this information cached into a map at the plugin level. In this way, we can access the pointer info "faster" and keep track of the pinned memory buffers that are OpenMP-related.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141227/new/

https://reviews.llvm.org/D141227



More information about the Openmp-commits mailing list