[Openmp-commits] [PATCH] D141227: [OpenMP][libomptarget] Implement memory lock/unlock API in NextGen plugins

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jan 8 15:32:56 PST 2023


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, with 3 nits:

- Ye's comment.
- The one below.
- @carlo.bertolli needs to modify the plugin interface and if we land this first we need to remember to change it as the other patch makes it in. Otherwise we can wait with this one.



================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1844-1847
+    void *PinnedPtr = nullptr;
 
     // Use one-step asynchronous operation when host memory is already pinned.
+    if ((PinnedPtr = PinnedAllocs.getDevicePtrFromPinnedBuffer(HstPtr))) {
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141227/new/

https://reviews.llvm.org/D141227



More information about the Openmp-commits mailing list