[Openmp-commits] [PATCH] D157725: Fix Slice Duplicate in Profiler

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:85
 
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
 
----------------
Keep this, put the RegionTypeMsg into the details field of the profile entry.


================
Comment at: openmp/libomptarget/src/interface.cpp:131
                                            void **ArgMappers) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   /// RAII to establish tool anchors before and after data begin
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:148
     void *NoAliasDepList) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   targetDataMapper<TaskAsyncInfoWrapperTy>(
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:163
                                          void **ArgMappers) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   /// RAII to establish tool anchors before and after data end
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:180
     void *NoAliasDepList) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   targetDataMapper<TaskAsyncInfoWrapperTy>(
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:192
                                             void **ArgMappers) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   /// RAII to establish tool anchors before and after data update
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:209
     void *NoAliasDepList) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   targetDataMapper<TaskAsyncInfoWrapperTy>(
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/interface.cpp:252
 
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
 
----------------
Keep this.


================
Comment at: openmp/libomptarget/src/interface.cpp:302
 
+  TIMESCOPE_WITH_IDENT(Loc);
+
----------------
Remove, above is better / more true to the time spend "offloading"


================
Comment at: openmp/libomptarget/src/interface.cpp:330
                                KernelArgsTy *KernelArgs) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   if (KernelArgs->Flags.NoWait)
----------------
Remove. 


================
Comment at: openmp/libomptarget/src/omptarget.cpp:534
                      TargetDataFuncPtrTy TargetDataFunction) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   DP("Calling the mapper function " DPxMOD "\n", DPxPTR(ArgMapper));
----------------
Remove, but verify all callees go through targetDataMapper<...>


================
Comment at: openmp/libomptarget/src/omptarget.cpp:575
                     void **ArgMappers, AsyncInfoTy &AsyncInfo,
                     bool FromMapper) {
   // process each input.
----------------
This is not tracked anymore.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1005
                                 int64_t ArgType, AsyncInfoTy &AsyncInfo) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   TargetPointerResultTy TPR =
----------------
Remove, but verify all callees go through targetDataMapper<...>


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1099
                                    AsyncInfoTy &AsyncInfo) {
-  TIMESCOPE_WITH_IDENT(Loc);
+  //TIMESCOPE_WITH_IDENT(Loc);
   int Ret = OFFLOAD_SUCCESS;
----------------
Remove, but verify all callees go through targetDataMapper<...>


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1144
+  
+  TIMESCOPE_WITH_IDNET(Loc);
+	
----------------
Remove, but verify all callees go through targetDataMapper<...>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157725/new/

https://reviews.llvm.org/D157725