[Openmp-commits] [PATCH] D157725: Fix Slice Duplicate in Profiler

[Aaron Jarmusch via Phabricator via Openmp-commits]

jarmusch added a comment.

Thanks, @tianshilei1992 for your input.

I adjusted the timescope calls to address a problem with duplicate profiling slices. You can see them on chrome://tracing. The duplication occurred when both kernel functions and all data-moving functions were timed separately. Focusing the timescope calls on 'targetKernel' and 'targetdataupdate' functions provides a solution to the duplicate slices, and more accurate profiling data, while keeping the important profiling.

My intention was to strike a balance between resolving the duplication issue and keeping the important profiling. I understand the importance of comprehensive profiling and I'm open to further discussion. F28692727: profile_ex.json <https://reviews.llvm.org/F28692727>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157725/new/

https://reviews.llvm.org/D157725