[Openmp-commits] [PATCH] D157725: Fix Slice Duplicate in Profiler

Tue Aug 15 19:42:03 PDT 2023

tianshilei1992 added a comment.

In D157725#4585647 <https://reviews.llvm.org/D157725#4585647>, @jarmusch wrote:

> Thanks, @tianshilei1992 for your input.
>
> I adjusted the timescope calls to address a problem with duplicate profiling slices. You can see them on chrome://tracing. The duplication occurred when both kernel functions and all data-moving functions were timed separately. Focusing the timescope calls on 'targetKernel' and 'targetdataupdate' functions provides a solution to the duplicate slices, and more accurate profiling data, while keeping the important profiling.
>
> My intention was to strike a balance between resolving the duplication issue and keeping the important profiling. I understand the importance of comprehensive profiling and I'm open to further discussion. F28705450: asmooth.json <https://reviews.llvm.org/F28705450> (Edited - change of file - the first file was after the fix - now you see the duplicate slices)

Okay. Then don't keep commented out code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157725/new/

https://reviews.llvm.org/D157725