[Openmp-commits] [PATCH] D148393: [OpenMP] Additional APIs used by MSVC compiler for loop collapse (rectangular and non-rectangular loops)

[Natalia Glagoleva via Phabricator via Openmp-commits]

natgla added a comment.

In D148393#4289199 <https://reviews.llvm.org/D148393#4289199>, @jhuber6 wrote:

> This broke my build, small subset of the errors below. Reverting the patch makes the errors go away.
>
>   In file included from /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:19:
>   /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:20: error: expected nested-name-specifier before ‘T’
>     152 |   typedef typename T span_t;
>         |                    ^

My bad. Vadim @vadikp-intel fixed this when committing. He also fixed ordinals (2 of the numbers were used somewhere in strange places in dllexports)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148393/new/

https://reviews.llvm.org/D148393