[Openmp-commits] [PATCH] D148393: [OpenMP] Additional APIs used by MSVC compiler for loop collapse (rectangular and non-rectangular loops)

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

This broke my build, small subset of the errors below. Reverting the patch makes the errors go away.

  In file included from /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:19:
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:20: error: expected nested-name-specifier before ‘T’
    152 |   typedef typename T span_t;
        |                    ^
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:20: error: expected ‘;’ at end of member declaration
    152 |   typedef typename T span_t;
        |                    ^
        |                     ;
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:20: error: declaration of ‘typedef int bounds_info_internalXX_template<T>::T’ shadows template parameter
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:138:11: note: template parameter ‘T’ declared here
    138 | template <typename T> struct bounds_info_internalXX_template {
        |           ^~~~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:22: error: ‘span_t’ does not name a type
    152 |   typedef typename T span_t;
        |                      ^~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:160:5: error: ‘span_t’ does not name a type
    160 |     span_t span_smallest;
        |     ^~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:168:5: error: ‘span_t’ does not name a type
    168 |     span_t span_biggest;
        |     ^~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp: In function ‘kmp_loop_nest_iv_t kmp_process_loop_nest(std::vector<bounds_info_internal_t>&)’:
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:763:33: warning: comparison of integer expressions of different signedness: ‘kmp_index_t’ {aka ‘int’} and ‘std::vector<bounds_info_internal_t>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
    763 |   for (kmp_index_t ind = 0; ind < bounds_nest.size(); ++ind) {
        |                             ~~~~^~~~~~~~~~~~~~~~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp: In function ‘kmp_loop_nest_iv_t kmp_calc_new_iv_from_original_ivs(const std::vector<bounds_info_internal_t>&, const kmp_point_t&)’:
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:869:33: warning: comparison of integer expressions of different signedness: ‘kmp_index_t’ {aka ‘int’} and ‘std::vector<bounds_info_internal_t>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
    869 |   for (kmp_index_t ind = 0; ind < bounds_nest.size(); ++ind) {
        |                             ~~~~^~~~~~~~~~~~~~~~~~~~
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp: In instantiation of ‘void kmp_calc_new_bounds_XX(bounds_info_internalXX_template<T>*, std::vector<bounds_info_internal_t>&) [with T = int]’:
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:748:25:   required from ‘kmp_loop_nest_iv_t kmp_process_one_loop_XX(bounds_info_internalXX_template<T>*, std::vector<bounds_info_internal_t>&) [with T = int; kmp_loop_nest_iv_t = long long unsigned int]’
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:769:54:   required from here
  /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:697:53: error: ‘struct bounds_info_internalXX_template<int>’ has no member named ‘span_biggest’
    697 |         T sub = (bbounds.lb1 - old_lb1) * previous->span_biggest;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148393/new/

https://reviews.llvm.org/D148393