[Openmp-commits] [PATCH] D148393: [OpenMP] Additional APIs used by MSVC compiler for loop collapse (rectangular and non-rectangular loops)

Fri Apr 21 22:59:05 PDT 2023

vzakhari added a comment.

In D148393#4289202 <https://reviews.llvm.org/D148393#4289202>, @natgla wrote:

> In D148393#4289199 <https://reviews.llvm.org/D148393#4289199>, @jhuber6 wrote:
>
>> This broke my build, small subset of the errors below. Reverting the patch makes the errors go away.
>>
>>   In file included from /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.cpp:19:
>>   /home/jhuber/Documents/llvm/llvm-project/openmp/runtime/src/kmp_collapse.h:152:20: error: expected nested-name-specifier before ‘T’
>>     152 |   typedef typename T span_t;
>>         |                    ^
>
> My bad. Vadim @vadikp-intel fixed this when committing. He also fixed ordinals (2 of the numbers were used somewhere in strange places in dllexports)

HI @natgla, @vadikp-intel, will you fix the issues?  I am not sure I understand from your comment what you are planning to do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148393/new/

https://reviews.llvm.org/D148393