[Openmp-commits] [PATCH] D100185: [OpenMP] [OMPD] [5/6] Implementation of OMPD debugging library - libompd. gdb-plugin: A Plugin code to gdb to leverage libompd to provide debugging support.

[Michał Górny via Phabricator via Openmp-commits]

mgorny added inline comments.


================
Comment at: openmp/libompd/CMakeLists.txt:14
     add_subdirectory(src)
+    if(NOT DISABLE_OMPD_GDB_PLUGIN)
+        add_subdirectory(gdb-plugin)
----------------
Vigneshbalu wrote:
> aaronpuchert wrote:
> > Could you introduce this as cache variable? Something like
> > ```
> > set(DISABLE_OMPD_GDB_PLUGIN OFF CACHE BOOL "<Some description>")
> > ```
> > See also https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry.
> > 
> > And perhaps we could choose the default based on the availability of Python 3 development files?
> thanks for the comments.
> I will make it as cache variable. 
> yes, we can disable when python is not available, with a warning.
> Let me check with others and update.
> 
> 
Also please use positive logic and `LIBOMP*` or `OPENMP*` prefix, for consistency with other options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100185/new/

https://reviews.llvm.org/D100185