[Openmp-commits] [PATCH] D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info

Mon Sep 5 00:10:44 PDT 2022

saiislam added a comment.

Apologies for the delay in response.

@scott.linder, this code is in OpenMP's admgpu plugin which is called by OpenMP device runtime.
Even though we are dependent on LLVM libraries, but I don't think we can access clang library from
here. Hence the logic replication.

@JonChesterfield, I first committed this patch as rG471f2abc62d9 <https://reviews.llvm.org/rG471f2abc62d96b3ef97e13f4f7be2d386fc9f75f> but it had to be reverted
(rG8cbf4a386b67 <https://reviews.llvm.org/rG8cbf4a386b6740180fe48aaebbd1ca9f8ee14367>) because AMDGPU builtbot was failing multiple libomptarget-amdgcn tests
(https://lab.llvm.org/buildbot/#/builders/193/builds/15846).

I fixed it by adding this initialization in the following commit (rG4075a811ad99 <https://reviews.llvm.org/rG4075a811ad99b7e263b8b99954cef8c96b042e22>).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127769/new/

https://reviews.llvm.org/D127769