[Openmp-commits] [PATCH] D133053: [Libomptarget] Change device free routines to accept the allocation kind

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D133053#3764266 <https://reviews.llvm.org/D133053#3764266>, @tianshilei1992 wrote:

> You can still use `_v2` or whatever in `libomptarget`. For `libomptarget`, there is no old interface then. Just keep the old one and all the logic for compatibility in the plugin. There is no confusion.

Then we'd have to keep the spurious hashtable inserts in alloc, and consider fixing the pointer leak in the current implementation (the table this deletes grows without bound). I.e. to keep things working for people that we don't have reason to believe exist, the cuda plugin must remain slower than it could be.

I can make my peace with that, but it looks like discarding this worthwhile patch, not applying it and taking the extra complexity without the benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133053/new/

https://reviews.llvm.org/D133053