[Openmp-commits] [PATCH] D133053: [Libomptarget] Change device free routines to accept the allocation kind

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D133053#3764266 <https://reviews.llvm.org/D133053#3764266>, @tianshilei1992 wrote:

> You can still use `_v2` or whatever in `libomptarget`. For `libomptarget`, there is no old interface then. Just keep the old one and all the logic for compatibility in the plugin. There is no confusion.

The potential change here is users who used `omp_target_free` to free non-device pointers as this worked before. We technically export the plugin routines as they need to be visible to `libomptarget` but I don't know if we expect any users to call them directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133053/new/

https://reviews.llvm.org/D133053