[Openmp-commits] [PATCH] D133053: [Libomptarget] Change device free routines to accept the allocation kind

Thu Sep 1 08:19:33 PDT 2022

tianshilei1992 added a comment.

In D133053#3764130 <https://reviews.llvm.org/D133053#3764130>, @jhuber6 wrote:

> In D133053#3764082 <https://reviews.llvm.org/D133053#3764082>, @tianshilei1992 wrote:
>
>> I think we'd better keep `__tgt_rtl_data_delete` unchanged, and add another interface. AFAIK we require `libomptarget` to be aligned with `clang`, but don't force the plugins.
>
> I figured it was okay to change since I don't recall if we actually provide backwards compatibility for the plugins.

Is it stated somewhere? I had a lot of trouble about compatibility before when I tried to change the interface. I'm okay with breaking the backward compatibility, as long as we already tell users. :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133053/new/

https://reviews.llvm.org/D133053