[Openmp-commits] [PATCH] D132925: Add LoongArch64 Support For OpenMP

Thu Sep 1 07:02:10 PDT 2022

SixWeining added reviewers: MaskRay, xen0n, wangleiat, xry111.
SixWeining added a comment.
Herald added a subscriber: StephenFan.

In D132925#3763451 <https://reviews.llvm.org/D132925#3763451>, @prcups wrote:

> Now I have fixed the problem(The cause is just about not saving return address before calling). Although that, it still failed 4 tests after I ran "make check-openmp". The failed tests are affinity/kmp-affinity.c, affinity/kmp-hw-subset.c, affinity/omp-places.c and teams/teams.c. I 'm not sure if it's necessary to care about and how to handle them. There are also 1 unexpextedly passed and 3 expectedly failed tests.
>
> The comment in CMakeList.txt has been fixed. The 1762-1770 lines in z_Linux_asm.S are just rubbish code I carelessly pasted.
>
> For the dot after comment, in z_Linux_asm.S, it is the same as riscv. Is it also necessary to modify them?

Excellent! I haven’t saw this ra issue when I review the patch.

I think you’re using gcc to build the openmp since clang currently is unable to build such complex programs, right?

AFAIK, some tests can only be run by clang. check-openmp is only part of all tests. There are some other targets like check-libomptarget IIRC. So I think it’s better to mention your testing environment, methods and results in the patch summary.

And I’m not a regular reviewer of the openmp subproject. Let’s wait others’ inputs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132925/new/

https://reviews.llvm.org/D132925