[Openmp-commits] [PATCH] D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info

Jonathan Peyton via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 28 06:27:07 PST 2022


jlpeyton added inline comments.


================
Comment at: openmp/runtime/test/tasking/bug_nested_proxy_task.c:23-29
+#ifdef _WIN64
+typedef long long kmp_intptr_t;
+#else
 typedef long kmp_intptr_t;
+#endif
 typedef int kmp_int32;
+typedef unsigned char kmp_uint8;
----------------
Can we `#include stdint.h` above and then use 
```
typedef intptr_t kmp_intptr_t;
typedef int32_t kmp_int32;
typedef uint8_t kmp_uint8;
```


================
Comment at: openmp/runtime/test/tasking/bug_proxy_task_dep_waiting.c:20-26
+#ifdef _WIN64
+typedef long long kmp_intptr_t;
+#else
 typedef long kmp_intptr_t;
+#endif
 typedef int kmp_int32;
+typedef unsigned char kmp_uint8;
----------------
Same as previous comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137748/new/

https://reviews.llvm.org/D137748



More information about the Openmp-commits mailing list