[Openmp-commits] [PATCH] D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo added inline comments.


================
Comment at: openmp/runtime/test/tasking/bug_nested_proxy_task.c:23-29
+#ifdef _WIN64
+typedef long long kmp_intptr_t;
+#else
 typedef long kmp_intptr_t;
+#endif
 typedef int kmp_int32;
+typedef unsigned char kmp_uint8;
----------------
jlpeyton wrote:
> Can we `#include stdint.h` above and then use 
> ```
> typedef intptr_t kmp_intptr_t;
> typedef int32_t kmp_int32;
> typedef uint8_t kmp_uint8;
> ```
That works for me too. But can we do it in two separate patches - first this, and then changing to using stdint.h? In case the stdint.h change breaks something unexpected in a weird environment and the change needs to be reverted, we'd still have the tests fixed on Win64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137748/new/

https://reviews.llvm.org/D137748