[Openmp-commits] [PATCH] D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info

Martin Storsjö via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 28 04:01:19 PST 2022


mstorsjo added a reviewer: DavidSpickett.
mstorsjo added a subscriber: DavidSpickett.
mstorsjo added a comment.

Adding @DavidSpickett here too, since he's been very helpful with review elsewhere. But feel free to skip this one if you feel it's out of scope for you.

There's basically two essential changes here, plus one optional:

- Use the right sized `intptr_t` instead of `long` for passing pointers in integers on Windows
- Zero-initialize a struct before we set individual flags in a bitfield (the library reads the bitfield as a complete integer instead of reading individual bits)

Optional:

- The test manually defines libomp internal data structures and passes such structs to the library. The struct definition in the test code differs vaguely from the real one used in libomp. Synchronize this to use the exact same definition as internally. This doesn't affect whether the tests pass or fail currently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137748/new/

https://reviews.llvm.org/D137748



More information about the Openmp-commits mailing list