[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Tue Nov 1 13:59:15 PDT 2022

natgla added inline comments.

================
Comment at: openmp/runtime/src/dllexports:1265
     __kmpc_atomic_val_8_cas_cpt            2158
+    %endif

----------------
mstorsjo wrote:
> @natgla - What about this change - was this something which was missed/forgotten and/or just not yet upstreamed from your work on openmp on MSVC/arm64?
this part wasn't broken for us - because libomp140 is still based on LLVM 11.

================
Comment at: openmp/runtime/src/kmp_os.h:621

+#elif KMP_ARCH_AARCH64 && defined(__GNUC__)
+
----------------
mstorsjo wrote:
> natgla wrote:
> > For MSVC we compiled libomp only with MSVC, so the patch is a bit different. @branh will start upstreaming the changes later this month, they will be complimentary to this change. 
> > Am I right that this patch will fix the issues only if compiled with gcc?
> > looks good to me.
> This patch fixes issues if compiled with clang in mingw mode - gcc doesn't support windows on aarch64 (yet).
Is this: "defined(__ GNUC __)" for mingw then? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168