[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Tue Nov 1 14:03:14 PDT 2022

branh added inline comments.

================
Comment at: openmp/runtime/src/dllexports:1265
     __kmpc_atomic_val_8_cas_cpt            2158
+    %endif

----------------
mstorsjo wrote:
> @natgla - What about this change - was this something which was missed/forgotten and/or just not yet upstreamed from your work on openmp on MSVC/arm64?
We haven't yet implemented OpenMP 5.1 on MSVC. We're finishing up OpenMP 3.1 support now.

For OpenMP 3.1, we did change this file to allow the various flavors of __kmpc_atomic_<type>_<opt>_cpt in the OpenMP 3.1 section on arm64. LLVM inlines the atomic lock acquisition/etc. instead, and so doesn't need these calls, but we haven't implemented that in MSVC yet.

It looks like your change is *removing* declarations for certain _cpt and _cas functions on arm64. If you expected us to need these functions on MSVC/arm64, wouldn't the current state be what we need? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168