[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo added a comment.

FWIW I tested this patch for a mingw/aarch64 environment, and at least a very small testcase does seem to run as expected.



================
Comment at: openmp/runtime/src/dllexports:1265
     __kmpc_atomic_val_8_cas_cpt            2158
+    %endif
 
----------------
@natgla - What about this change - was this something which was missed/forgotten and/or just not yet upstreamed from your work on openmp on MSVC/arm64?


================
Comment at: openmp/runtime/src/kmp_os.h:621
 
+#elif KMP_ARCH_AARCH64 && defined(__GNUC__)
+
----------------
natgla wrote:
> For MSVC we compiled libomp only with MSVC, so the patch is a bit different. @branh will start upstreaming the changes later this month, they will be complimentary to this change. 
> Am I right that this patch will fix the issues only if compiled with gcc?
> looks good to me.
This patch fixes issues if compiled with clang in mingw mode - gcc doesn't support windows on aarch64 (yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168