[Openmp-commits] [PATCH] D137168: [OpenMP][mingw] Fix build for aarch64 target

Natalia Glagoleva via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 1 13:36:27 PDT 2022


natgla added inline comments.


================
Comment at: openmp/runtime/src/kmp_os.h:621
 
+#elif KMP_ARCH_AARCH64 && defined(__GNUC__)
+
----------------
For MSVC we compiled libomp only with MSVC, so the patch is a bit different. @branh will start upstreaming the changes later this month, they will be complimentary to this change. 
Am I right that this patch will fix the issues only if compiled with gcc?
looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137168/new/

https://reviews.llvm.org/D137168



More information about the Openmp-commits mailing list