[Openmp-commits] [PATCH] D125698: [Libomptarget] Don't build the device runtime without a new Clang

Ye Luo via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon May 16 12:47:01 PDT 2022


ye-luo accepted this revision.
ye-luo added a comment.
This revision is now accepted and ready to land.

Restored gcc build in my tests.



================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:269
 
 add_subdirectory(src)
----------------
jhuber6 wrote:
> protze.joachim wrote:
> > This line will be skipped, if the return hits. Is this the intended behavior?
> Yes, that directly is only used by the above target library. The previous method just grabbed all the sources directly.
I think the way of building omptarget.devicertl needs to be changed. It is doing differently from others and confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125698/new/

https://reviews.llvm.org/D125698



More information about the Openmp-commits mailing list