[Openmp-commits] [PATCH] D125260: [Libomptarget] Allow the device runtime to be compiled for the host

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM. Just would be better to add comments for those forward declaration.



================
Comment at: openmp/libomptarget/DeviceRTL/src/Mapping.cpp:26
 namespace impl {
 
+const llvm::omp::GV &getGridValue();
----------------
Could you add some comments here saying that's just a declaration and every target has to implement them.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:66
 
+uint32_t atomicInc(uint32_t *A, uint32_t V, int Ordering);
+void namedBarrierInit();
----------------
similar here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125260/new/

https://reviews.llvm.org/D125260