[Openmp-commits] [PATCH] D119676: [OpenMP] libomp: implemented task priorities.

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

For the test I suggest signalling like used for OMPT tests (see openmp/runtime/tests/ompt/ompt_signal.h) to enforce the execution ordering rather than sleep "synchronization".



================
Comment at: openmp/runtime/test/tasking/omp_task_priority2.c:60
+    } else {
+      delay(1500); // sleep 1.5 sec (let master to execute tasks)
+    }
----------------
Since you already have the shared atomic variable `passed`, you can wait for the expected value in this variable.


================
Comment at: openmp/runtime/test/tasking/omp_task_priority2.c:101-103
+      delay(1500); // sleep 1.5 sec (let worker to execute tasks)
+    } else {
+      delay(200); // sleep a bit to let tasks be generated
----------------
Similar for the second parallel region


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119676/new/

https://reviews.llvm.org/D119676