[Openmp-commits] [PATCH] D119676: [OpenMP] libomp: implemented task priorities.

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton added a comment.

Few comments below, and just for clarification, is it correct that priority==0 means "use the regular per-thread deques" and are assumed to be lowest (and default) priority?



================
Comment at: openmp/runtime/src/kmp_tasking.cpp:336
+
+static kmp_thread_data_t *__kmp_get_th_data(kmp_task_team_t *task_team,
+                                            kmp_int32 pri) {
----------------
I know this function returns a structure called `kmp_thread_data_t` here, but it would be easier to read if it was named `__kmp_get_priority_deque()` or similar since that is the really the semantics. I thought the priority queues were per-thread until looking closely.


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:344
+  } else if (lst->priority < pri) {
+    // Existed queues keep tasks with lower priority.
+    // Allocate new one for given priority tasks.
----------------
"Existed queues keep" -> "All current priority queues contain"

Maybe just outright mention the list of priority queues are sorted from high -> low.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119676/new/

https://reviews.llvm.org/D119676