[Openmp-commits] [PATCH] D117211: [openmp] Mark used variables as retain as well

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 13 08:53:37 PST 2022


JonChesterfield added a comment.

See D97446 <https://reviews.llvm.org/D97446>. Used no longer means "used by something so don't delete it".

I don't know why we had no multiply defined symbol errors with the old versit, should have done. Maybe lucky interleaving of the breaking change to the attribute with the changes to the driver.

Tests in trunk don't use the environment variable, so didn't notice it missing / containing zero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117211/new/

https://reviews.llvm.org/D117211



More information about the Openmp-commits mailing list