[Openmp-commits] [PATCH] D117211: [openmp] Mark used variables as retain as well

Thu Jan 13 08:55:32 PST 2022

jdoerfert added a comment.

In D117211#3240933 <https://reviews.llvm.org/D117211#3240933>, @JonChesterfield wrote:

> See D97446 <https://reviews.llvm.org/D97446>. Used no longer means "used by something so don't delete it".
>
> I don't know why we had no multiply defined symbol errors with the old version, should have done. Maybe lucky interleaving of the breaking change to the attribute with the changes to the driver.
>
> Tests in trunk don't use the environment variable, so didn't notice it missing / containing zero.

That doesn't help me. When is the variable be deleted?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117211/new/

https://reviews.llvm.org/D117211