[Openmp-commits] [PATCH] D117211: [openmp] Mark used variables as retain as well

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 13 08:50:02 PST 2022


jdoerfert reopened this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

This might have broke nvidia and I'm not sure I understand the logic.

Why do we need retain? When is the variable being removed? I have seen problems w/ AMDGPU offloading when globals are hidden and then not exposed, is that the same problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117211/new/

https://reviews.llvm.org/D117211



More information about the Openmp-commits mailing list