[Openmp-commits] [PATCH] D114274: [openmp][amdgpu] Make plugin robust to presence of explicit implicit arguments

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:475
 
+        if (lcArg.valueKind_ == KernelArgMD::ValueKind::HiddenHostcallBuffer) {
+          if (info.hostcall_pointer_offset != UINT32_MAX) {
----------------
There's some evidence suggesting clang won't emit this metadata (or the printf one), it may actually emit
```
{
".address_space" : "global",
".offset" : 24,
".size" : 8,
".value_kind" : "hidden_none",
},
```
as a placeholder to indicate it doesn't know the print/hostcall thing is needed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114274/new/

https://reviews.llvm.org/D114274