[Openmp-commits] [PATCH] D114274: [openmp][amdgpu] Make plugin robust to presence of explicit implicit arguments

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Nov 19 12:58:07 PST 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:495
 
-    // TODO: Probably don't want this arithmetic 
+    // TODO: Probably don't want this arithmetic
     info.kernel_segment_size =
----------------
arsenm wrote:
> probably shouldn't touch this line until it's deleted
i missed clang-format on a previous patch, but not on this one. Doesn't seem worth going through and putting the whitespace back in


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114274/new/

https://reviews.llvm.org/D114274



More information about the Openmp-commits mailing list