[Openmp-commits] [PATCH] D99553: [libomptarget] Read standard notes for ELF offload images

Thu Apr 8 09:52:32 PDT 2021

JonChesterfield added a comment.

In D99553#2677180 <https://reviews.llvm.org/D99553#2677180>, @vzakhari wrote:

> Note that in D93055 <https://reviews.llvm.org/D93055> there is still a path for OPENMP_STANDALONE_BUILD.  I believe we have not yet abandoned the out-of-tree builds (https://openmp.llvm.org/README.txt).  And it seems like a big change to me.

That is true. I'm under the impression that a 'standalone build' means one without LLVM, in which case we would hit

  # LLVM source tree is required at build time for libomptarget                                                                                                                                                      
  if (NOT LIBOMPTARGET_LLVM_INCLUDE_DIRS)
    message(FATAL_ERROR "Missing definition for LIBOMPTARGET_LLVM_INCLUDE_DIRS")
  endif()

in which case the branch in D93055 <https://reviews.llvm.org/D93055> for standalone build would be dead, but 'standalone build' might not mean what I think it does.

The current status, as I understand it, is libomp can build without llvm available, but libomptarget requires a copy of llvm on disk and optionally a copy of the llvm support library.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99553/new/

https://reviews.llvm.org/D99553