[Openmp-commits] [PATCH] D99553: [libomptarget] Read standard notes for ELF offload images

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added a comment.

In D99553#2677146 <https://reviews.llvm.org/D99553#2677146>, @JonChesterfield wrote:

> In D99553#2677114 <https://reviews.llvm.org/D99553#2677114>, @vzakhari wrote:
>
>> Hi Jon,
>> Regarding the LLVM component libraries linking into the libomptarget/plugins, I guess the bigger change is that OpenMP offload runtime will not build in out-of-tree mode.  Should we actually start with disabling the out-of-tree builds, and see how people react to this?
>
> If I understand you correctly, we took that step some time ago. If you check the libomptarget cmake there's some logic that tries to find the rest of llvm and bails if it isn't available. That is currently used to allow including llvm headers - at least the amdgpu plugin does so to keep enums consistent between clang and the plugin. The most recent attempt to unconditionally link a llvm binary is discussed in the comments of D93055 <https://reviews.llvm.org/D93055>

Note that in D93055 <https://reviews.llvm.org/D93055> there is still a path for OPENMP_STANDALONE_BUILD.  I believe we have not yet abandoned the out-of-tree builds (https://openmp.llvm.org/README.txt).  And it seems like a big change to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99553/new/

https://reviews.llvm.org/D99553