[Openmp-commits] [PATCH] D99553: [libomptarget] Read standard notes for ELF offload images

[Vyacheslav Zakharin via Phabricator via Openmp-commits]

vzakhari added a comment.

> The current status, as I understand it, is libomp can build without llvm available, but libomptarget requires a copy of llvm on disk and optionally a copy of the llvm support library.

You are right, libomptarget requires a copy of llvm on disk (for the header files).  At the same time just a copy of the llvm support library is not enough to use, e.g. for profiling or something else.  You may see that D93055 <https://reviews.llvm.org/D93055> uses add_llvm_library() that is simply not available in an out-of-tree build.  In this change-set I am using llvm_update_compile_flags(), which also requires true in-tree build.  Maybe we can make these macros available by using find_package(LLVM), but I am not sure about that.

So I believe getting rid of libelf dependency implies strong requirement for a true in-tree build, and this is a big change for downstream projects.  I am not sure how I should approach this major shift.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99553/new/

https://reviews.llvm.org/D99553