[Openmp-commits] [PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D87946#2286434 <https://reviews.llvm.org/D87946#2286434>, @grokos wrote:

> Correct, all `__tgt_target_*` functions not ending in `_mapper` are part of the old interface and we are keeping them for compatibility with older versions of clang. These older clang versions do not emit the location pointer anyway, so this extra argument should be removed and each such function should call into its new API equivalent passing a `nullptr`.
>
> We need the location pointer only for `__tgt_target_*_mapper` functions as well as `__kmpc_push_target_tripcount` - this is the current interface.

Since the functions are `extern "C"` I'll need to rename them to something else to keep them backwards compatible and then change what current Clang generates. something like `__tgt_target_mapper_loc`? Seems like a hacky solution to just keep adding suffixed whenever we want a new interface though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946