[Openmp-commits] [PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

In D87946#2286413 <https://reviews.llvm.org/D87946#2286413>, @jhuber6 wrote:

> I wasn't aware they were explicitly deprecated. If we're keeping around old interfaces for backwards compatibility I should also add in the old mapper functions without the `ident_t` pointer and call into the new functions with a nullptr.

Correct, all `__tgt_target_*` functions not ending in `_mapper` are part of the old interface and we are keeping them for compatibility with older versions of clang. These older clang versions do not emit the location pointer anyway, so this extra argument should be removed and each such function should call into its new API equivalent passing a `nullptr`.

We need the location pointer only for `__tgt_target_*_mapper` functions as well as `__kmpc_push_target_tripcount` - this is the current interface.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946