[Openmp-commits] [PATCH] D87165: [OpenMP] Begin Printing Information Dumps In Libomptarget and Plugins

Fri Sep 4 16:20:43 PDT 2020

jdoerfert added inline comments.

================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:932
+          CudaBlocksPerGrid, CudaThreadsPerBlock, 
+          (KernelInfo->ExecutionMode == SPMD)? "SPMD" : "Generic");

----------------
jhuber6 wrote:
> jdoerfert wrote:
> > Forgot, we need to print the device number here too. Also the kernel name if we have it. That name is not great but has the line number in it (IIRC).
> > 
> > Maybe add a first mandatory argument to the INFO macro that is the device number. Then we can always forward something like: `"[OMP-INFO][Device %d] " __VAR_ARGS__`.
> > I see we already have the first part (to some degree) adding the  device part would be good (I think).
> You mean using the CUDA RTL to get the name from the CUfunction value in the KernelTy struct?
We add it to KernelTy. When we do `KernelsList.emplace_back(Func, ExecModeVal);` in rtl.cpp, we know the name.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87165/new/

https://reviews.llvm.org/D87165