[Openmp-commits] [PATCH] D87165: [OpenMP] Begin Printing Information Dumps In Libomptarget and Plugins

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:932
+          CudaBlocksPerGrid, CudaThreadsPerBlock, 
+          (KernelInfo->ExecutionMode == SPMD)? "SPMD" : "Generic");
 
----------------
jdoerfert wrote:
> Forgot, we need to print the device number here too. Also the kernel name if we have it. That name is not great but has the line number in it (IIRC).
> 
> Maybe add a first mandatory argument to the INFO macro that is the device number. Then we can always forward something like: `"[OMP-INFO][Device %d] " __VAR_ARGS__`.
> I see we already have the first part (to some degree) adding the  device part would be good (I think).
You mean using the CUDA RTL to get the name from the CUfunction value in the KernelTy struct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87165/new/

https://reviews.llvm.org/D87165