[Openmp-commits] [PATCH] D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

What do you think about adding assertions or warnings for the cases that "should not happen"?



================
Comment at: openmp/tools/archer/ompt-tsan.cpp:670
-    break;
   }
 }
----------------
protze.joachim wrote:
> jdoerfert wrote:
> > I don't get these changes. Don't we just silently ignore other endpoint values now? Does it make sense to make it explicit?
> I can go back to the switch statement and list ompt_scope_beginend explicitly. For this callback, ompt_scope_beginend cannot be used according to the OpenMP spec.
can we at least use an assert or warning or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90758/new/

https://reviews.llvm.org/D90758