[Openmp-commits] [PATCH] D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/tools/archer/ompt-tsan.cpp:558
-  switch (endpoint) {
-  case ompt_scope_begin:
     TsanFuncEntry(codeptr_ra);
----------------
Keeping the switch here would look like:

```
switch (endpoint) {
case ompt_scope_begin:
case ompt_scope_beginend:
...
if (endpoint == ompt_scope_begin) break;
[[fallthrough]]
case ompt_scope_end:
...
```



================
Comment at: openmp/tools/archer/ompt-tsan.cpp:670
-    break;
   }
 }
----------------
jdoerfert wrote:
> I don't get these changes. Don't we just silently ignore other endpoint values now? Does it make sense to make it explicit?
I can go back to the switch statement and list ompt_scope_beginend explicitly. For this callback, ompt_scope_beginend cannot be used according to the OpenMP spec.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90758/new/

https://reviews.llvm.org/D90758