[Openmp-commits] [PATCH] D90758: [OpenMP][Tool] Update archer to accept new OpenMP 5.1 enum values

Joachim Protze via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 12 03:31:16 PST 2020


protze.joachim updated this revision to Diff 304767.
protze.joachim edited the summary of this revision.
protze.joachim added a comment.

I acknowledge the advantage of switch statements, in that they will warn on missing cases in the future. So, I went back to the switch statements.

Regarding the assertions for the cases, which should not happen: I think, this should be covered by the OMPT tests. The OMPT tests fail, if such unexpected callback arguments are passed. Archer can just happily ignore these cases and I added comments for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90758/new/

https://reviews.llvm.org/D90758

Files:
  openmp/tools/archer/ompt-tsan.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90758.304767.patch
Type: text/x-patch
Size: 3460 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20201112/b727025c/attachment.bin>


More information about the Openmp-commits mailing list