[Openmp-commits] [PATCH] D84487: [OpenMP] Add more pass-through functions in DeviceTy

[Ye Luo via Phabricator via Openmp-commits]

ye-luo marked an inline comment as done.
ye-luo added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:357
+  return RTL->data_alloc(RTLDeviceID, Size, nullptr);
+}
+
----------------
jdoerfert wrote:
> I guess the `HostPtr` is never used by any RTL?
It seems never used.


================
Comment at: openmp/libomptarget/src/device.cpp:362
+  return RTL->data_delete(RTLDeviceID, TgtPtrBegin);
+}
+
----------------
jdoerfert wrote:
> No function comments here then.
Where you asking for comments of "DeviceTy::data_delete" or "return RTL->data_delete(RTLDeviceID, TgtPtrBegin);"?
For the former, if we have it in the header, do we still need to repeat the same comment at function definition?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84487/new/

https://reviews.llvm.org/D84487