[Openmp-commits] [PATCH] D84487: [OpenMP] Add more pass-through functions in DeviceTy

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:362
+  return RTL->data_delete(RTLDeviceID, TgtPtrBegin);
+}
+
----------------
ye-luo wrote:
> jdoerfert wrote:
> > No function comments here then.
> Where you asking for comments of "DeviceTy::data_delete" or "return RTL->data_delete(RTLDeviceID, TgtPtrBegin);"?
> For the former, if we have it in the header, do we still need to repeat the same comment at function definition?
https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
Don’t duplicate the documentation comment in the header file and in the implementation file.
I'm not sure I understand what you were asking for here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84487/new/

https://reviews.llvm.org/D84487