[Openmp-commits] [PATCH] D84487: [OpenMP] Add more pass-through functions in DeviceTy

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Thx for the cleanup, minor comments below.



================
Comment at: openmp/libomptarget/src/device.cpp:357
+  return RTL->data_alloc(RTLDeviceID, Size, nullptr);
+}
+
----------------
I guess the `HostPtr` is never used by any RTL?


================
Comment at: openmp/libomptarget/src/device.cpp:362
+  return RTL->data_delete(RTLDeviceID, TgtPtrBegin);
+}
+
----------------
No function comments here then.


================
Comment at: openmp/libomptarget/src/device.cpp:441
+  return OFFLOAD_SUCCESS;
+}
+
----------------
same as above.


================
Comment at: openmp/libomptarget/src/device.h:197
+  void *data_alloc(int64_t Size);
+  int32_t data_delete(void *TgtPtrBegin);
+
----------------
While we are at it, comments for both, full sentences, explain the result of delete.


================
Comment at: openmp/libomptarget/src/device.h:221
+  // synchronize device/queue/event based on AsyncInfoPtr
+  int32_t synchronize(__tgt_async_info *AsyncInfoPtr);
+
----------------
Same as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84487/new/

https://reviews.llvm.org/D84487