[Openmp-commits] [openmp] ab9762a - Revert "[nfc][libomptarget] Remove SHARED annotation from local variables"

Jon Chesterfield via Openmp-commits openmp-commits at lists.llvm.org
Mon Jan 27 12:05:31 PST 2020


Author: Jon Chesterfield
Date: 2020-01-27T20:05:17Z
New Revision: ab9762a9f574207e1dbf2d82a13f68b0b434fc39

URL: https://github.com/llvm/llvm-project/commit/ab9762a9f574207e1dbf2d82a13f68b0b434fc39
DIFF: https://github.com/llvm/llvm-project/commit/ab9762a9f574207e1dbf2d82a13f68b0b434fc39.diff

LOG: Revert "[nfc][libomptarget] Remove SHARED annotation from local variables"

This reverts commit 0e9374e3740f82f2d46af564f6b059e68ff307c8.
Revert D73239. It fails some local testing, cause presently unknown

Added: 
    

Modified: 
    openmp/libomptarget/deviceRTLs/common/src/reduction.cu

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/deviceRTLs/common/src/reduction.cu b/openmp/libomptarget/deviceRTLs/common/src/reduction.cu
index 44e32cde8789..7f6ee2e39c7d 100644
--- a/openmp/libomptarget/deviceRTLs/common/src/reduction.cu
+++ b/openmp/libomptarget/deviceRTLs/common/src/reduction.cu
@@ -230,7 +230,7 @@ static int32_t nvptx_teams_reduce_nowait(int32_t global_tid, int32_t num_vars,
                           : /*Master thread only*/ 1;
   uint32_t TeamId = GetBlockIdInKernel();
   uint32_t NumTeams = GetNumberOfBlocksInKernel();
-  volatile bool IsLastTeam;
+  SHARED volatile bool IsLastTeam;
 
   // Team masters of all teams write to the scratchpad.
   if (ThreadId == 0) {
@@ -423,8 +423,8 @@ EXTERN int32_t __kmpc_nvptx_teams_reduce_nowait_v2(
                          : /*Master thread only*/ 1;
   uint32_t TeamId = GetBlockIdInKernel();
   uint32_t NumTeams = GetNumberOfBlocksInKernel();
-  unsigned Bound;
-  unsigned ChunkTeamCount;
+  SHARED unsigned Bound;
+  SHARED unsigned ChunkTeamCount;
 
   // Block progress for teams greater than the current upper
   // limit. We always only allow a number of teams less or equal


        


More information about the Openmp-commits mailing list