[Openmp-commits] [PATCH] D72956: [libomptarget] Implement smid for amdgcn

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, I mean it is black magic but that is to be expected. One comment below.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_smid.hip:56
+  }
+*/
+
----------------
I would prefer these to be ENUMs with documentation instead of defines. I would also opt for // comments instead.

Other than that I just believe you this does something useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72956/new/

https://reviews.llvm.org/D72956